[patch] Start fixing pr24429

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 13 18:20:17 PDT 2015


So, is everyone OK with this? I don't really have a preference as to
where the enum lives, but it should live in one place and not two.

On 12 August 2015 at 12:27, Dan Gohman <dan433584 at gmail.com> wrote:
> On Wed, Aug 12, 2015 at 8:37 AM, Rafael EspĂ­ndola
> <rafael.espindola at gmail.com> wrote:
>>> It does remove information from MCObjectFileInfo though. Is it really
>>> desirable to pick the Triple to be the one that gets to keep this
>>> information, rather than the other way around? I don't have a clear
>>> view of where this is headed.
>>
>> Even if we move it out of the triple, IMHO it is a good step to first
>> have a single location.
>>
>> And given that we support things like x86_64-pc-windows-elf in the
>> command line, having this information on the Triple c++ object also
>> seems reasonable to me. If we remove it from one place we should also
>> remove it from the other.
>
> I don't know what x86_64-pc-windows-elf is, or why it isn't just
> parsed into just a WindowsElf OSType. I'll let the people who know
> more about this topic than me make the decisions here.
>
> Dan


More information about the llvm-commits mailing list