[PATCH] D11612: [lld][ELF2] Apply relocations.

[Sean Silva via llvm-commits]

silvas added a subscriber: silvas.

================
Comment at: test/elf2/relocation.test:1
@@ +1,2 @@
+# RUN: yaml2obj -format elf %s -docnum 1 -o %t1obj
+# RUN: yaml2obj -format elf %s -docnum 2 -o %t2obj
----------------
rafael wrote:
> llvm-mc
That doesn't make sense. It's like using a C file for an LLVM IR test. If we are testing relocations, there better be `R_` in the input and not in a comment.

================
Comment at: test/elf2/relocation.test:30-38
@@ +29,11 @@
+        Addend:          -4
+  - Name:            .data
+    Type:            SHT_PROGBITS
+    Flags:           [ SHF_WRITE, SHF_ALLOC ]
+    AddressAlign:    0x0000000000000004
+    Content:         ''
+  - Name:            .bss
+    Type:            SHT_NOBITS
+    Flags:           [ SHF_WRITE, SHF_ALLOC ]
+    AddressAlign:    0x0000000000000004
+Symbols:         
----------------
Delete the data and bss sections. They don't matter for this test.

================
Comment at: test/elf2/relocation.test:71
@@ +70,3 @@
+      Type:            STT_FUNC
+      Section:         .text
+...
----------------
For clarity, please have an explicit offset here.


http://reviews.llvm.org/D11612