[llvm] r244953 - MIR Parser: Don't allow negative alignments for memory operands.

[Alex Lorenz via llvm-commits]

Author: arphaman
Date: Thu Aug 13 15:55:01 2015
New Revision: 244953

URL: http://llvm.org/viewvc/llvm-project?rev=244953&view=rev
Log:
MIR Parser: Don't allow negative alignments for memory operands.

Added:
    llvm/trunk/test/CodeGen/MIR/X86/expected-positive-alignment-after-align.mir
Modified:
    llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp

Modified: llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp?rev=244953&r1=244952&r2=244953&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp (original)
+++ llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp Thu Aug 13 15:55:01 2015
@@ -1077,7 +1077,7 @@ bool MIParser::parseOffset(int64_t &Offs
 bool MIParser::parseAlignment(unsigned &Alignment) {
   assert(Token.is(MIToken::kw_align));
   lex();
-  if (Token.isNot(MIToken::IntegerLiteral))
+  if (Token.isNot(MIToken::IntegerLiteral) || Token.integerValue().isSigned())
     return error("expected an integer literal after 'align'");
   if (getUnsigned(Alignment))
     return true;

Added: llvm/trunk/test/CodeGen/MIR/X86/expected-positive-alignment-after-align.mir
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/MIR/X86/expected-positive-alignment-after-align.mir?rev=244953&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/MIR/X86/expected-positive-alignment-after-align.mir (added)
+++ llvm/trunk/test/CodeGen/MIR/X86/expected-positive-alignment-after-align.mir Thu Aug 13 15:55:01 2015
@@ -0,0 +1,32 @@
+# RUN: not llc -march=x86-64 -start-after branch-folder -stop-after branch-folder -o /dev/null %s 2>&1 | FileCheck %s
+
+--- |
+
+  define void @memory_alignment(<8 x float>* %vec) {
+  entry:
+    %v = load <8 x float>, <8 x float>* %vec
+    %v2 = insertelement <8 x float> %v, float 0.0, i32 4
+    store <8 x float> %v2, <8 x float>* %vec
+    ret void
+  }
+
+...
+---
+name:            memory_alignment
+tracksRegLiveness: true
+liveins:
+  - { reg: '%rdi' }
+body:
+  - id:          0
+    name:        entry
+    liveins:     [ '%rdi' ]
+    instructions:
+# CHECK: [[@LINE+1]]:76: expected an integer literal after 'align'
+      - '%xmm0 = MOVAPSrm %rdi, 1, _, 0, _ :: (load 16 from %ir.vec, align -32)'
+      - '%xmm1 = MOVAPSrm %rdi, 1, _, 16, _ :: (load 16 from %ir.vec + 16, align 32)'
+      - '%xmm2 = FsFLD0SS'
+      - '%xmm1 = MOVSSrr killed %xmm1, killed %xmm2'
+      - 'MOVAPSmr %rdi, 1, _, 0, _, killed %xmm0 :: (store 16 into %ir.vec, align 32)'
+      - 'MOVAPSmr killed %rdi, 1, _, 16, _, killed %xmm1 :: (store 16 into %ir.vec + 16, align 32)'
+      - RETQ
+...