[PATCH] D12019: [windows] Fix or XFAIL remaining portable test failures and enable them

[Alexey Samsonov via llvm-commits]

samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: test/asan/TestCases/coverage-disabled.cc:8
@@ -7,3 +7,3 @@
 // RUN: mkdir -p %T/coverage-disabled/normal
-// RUN: %env_asan_opts=coverage_direct=0:coverage_dir=%T/coverage-disabled/normal:verbosity=1 %run %t
+// RUN: %env_asan_opts=coverage_direct=0:coverage_dir='"%T/coverage-disabled/normal"':verbosity=1 %run %t
 // RUN: not %sancov print %T/coverage-disabled/normal/*.sancov 2>&1
----------------
Do you really need both kinds of quotes?

================
Comment at: test/asan/TestCases/debug_report.cc:25
@@ +24,3 @@
+#ifdef _MSC_VER
+#ifdef _WIN64
+#define PTR_FMT "0x%08llx"
----------------
Please use identation here

  #ifdef _MSC_VER
  # ifdef _WIN64
  #  define PTR_FMT ...


================
Comment at: test/asan/TestCases/interception_failure_test.cc:8
@@ -7,2 +7,3 @@
 // RUN: %clangxx_asan -O3 %s -o %t && %run %t 2>&1 | FileCheck %s
-// XFAIL: freebsd
+// On Windows, defining strtoll results in linker errors.
+// XFAIL: freebsd,win32
----------------
If the interception machinery works differently on Windows, just move this to Posix/ ?

================
Comment at: test/asan/TestCases/null_deref.cc:7
@@ -6,3 +6,3 @@
 __attribute__((noinline))
-static void NullDeref(int *ptr) {
-  // CHECK: ERROR: AddressSanitizer: SEGV on unknown address
+// FIXME: Static symbols don't show up in PDBs. We can remove this when using
+// dwarf.
----------------
"once we start using DWARF"


http://reviews.llvm.org/D12019