[PATCH] D11961: [sancov] Leave llvm.localescape in the entry block

[Reid Kleckner via llvm-commits]

rnk added inline comments.

================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1805-1806
@@ -1806,4 +1804,4 @@
 
-  // If we have a call to llvm.localescape, keep it in the entry block.
-  if (LocalEscapeCall) LocalEscapeCall->moveBefore(InsBefore);
+  // Keep entry block intrinsics like llvm.localescape in the entry.
+  InsBefore = PrepareToSplitEntryBlock(*InsBeforeB, InsBefore);
 
----------------
Hm, this change fails because it moves instrumented static allocas around. Coverage and other instrumentation passes that don't replace static allocas don't have this problem. I think we should leave asan alone.


http://reviews.llvm.org/D11961