[PATCH] D10956: [mips][microMIPS] Add microMIPS32r6 and microMIPS64r6 tests for existing 16-bit LBU16, LHU16, LW16, LWGP and LWSP instructions

[Daniel Sanders via llvm-commits]

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with a test for the lbu special case


================
Comment at: test/MC/Mips/micromips32r6/valid.s:65
@@ -61,1 +64,3 @@
+  lhu16 $3, 4($16)         # CHECK: lhu16 $3, 4($16)    # encoding: [0x29,0x82]
+  lbu16 $3, 4($17)         # CHECK: lbu16 $3, 4($17)    # encoding: [0x09,0x94]
 
----------------
An offset of -1 is a special case for lbu16 (the encoding is unsigned except for 0xf which is -1). We should test that too.

================
Comment at: test/MC/Mips/micromips64r6/valid.s:15
@@ -11,1 +14,3 @@
+        lhu16 $3, 4($16)         # CHECK: lhu16 $3, 4($16)      # encoding: [0x29,0x82]
+        lbu16 $3, 4($17)         # CHECK: lbu16 $3, 4($17)      # encoding: [0x09,0x94]
 
----------------
Same here.


http://reviews.llvm.org/D10956