[llvm] r244885 - Revert "[LIR] Start leveraging the fundamental guarantees of a loop..."

[Renato Golin via llvm-commits]

Author: rengolin
Date: Thu Aug 13 06:25:38 2015
New Revision: 244885

URL: http://llvm.org/viewvc/llvm-project?rev=244885&view=rev
Log:
Revert "[LIR] Start leveraging the fundamental guarantees of a loop..."

This reverts commit r244879, as it broke the test-suite on
SingleSource/Regression/C/2004-03-15-IndirectGoto in AArch64.

Modified:
    llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp?rev=244885&r1=244884&r2=244885&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp Thu Aug 13 06:25:38 2015
@@ -830,32 +830,29 @@ bool LoopIdiomRecognize::recognizePopcou
   // non-compact loop. Therefore, recognizing popcount idiom only makes sense
   // in a compact loop.
 
-  assert(CurLoop->isLoopSimplifyForm() &&
-         "Loop passes require simplified form!");
-
-  // Give up if the loop has multiple blocks.
-  if (CurLoop->getNumBlocks() != 1)
+  // Give up if the loop has multiple blocks or multiple backedges.
+  if (CurLoop->getNumBackEdges() != 1 || CurLoop->getNumBlocks() != 1)
     return false;
 
-  // If the loop is too big, bail out.
-  BasicBlock &LoopBB = *CurLoop->getHeader();
-  if (LoopBB.size() >= 20)
+  BasicBlock *LoopBody = *(CurLoop->block_begin());
+  if (LoopBody->size() >= 20) {
+    // The loop is too big, bail out.
     return false;
+  }
 
   // It should have a preheader containing nothing but an unconditional branch.
-  BasicBlock &PH = *CurLoop->getLoopPreheader();
-  if (&PH.front() != PH.getTerminator())
+  BasicBlock *PH = CurLoop->getLoopPreheader();
+  if (!PH)
+    return false;
+  if (&PH->front() != PH->getTerminator())
     return false;
-  // FIXME: Technically, it shouldn't matter what instruction we use as
-  // a terminator, the only property needed is the definition of a preheader:
-  // a single loop predecessor whose only successor is the loop header.
-  auto *EntryBI = dyn_cast<BranchInst>(PH.getTerminator());
+  auto *EntryBI = dyn_cast<BranchInst>(PH->getTerminator());
   if (!EntryBI || EntryBI->isConditional())
     return false;
 
   // It should have a precondition block where the generated popcount instrinsic
   // function can be inserted.
-  auto *PreCondBB = PH.getSinglePredecessor();
+  auto *PreCondBB = PH->getSinglePredecessor();
   if (!PreCondBB)
     return false;
   auto *PreCondBI = dyn_cast<BranchInst>(PreCondBB->getTerminator());