[PATCH] D11782: RFC: Target-specific loop idiom recognition

[Hal Finkel via llvm-commits]

See also my comments here: http://lists.llvm.org/pipermail/llvm-dev/2015-August/089190.html

 -Hal

----- Original Message -----
> From: "James Molloy" <james.molloy at arm.com>
> To: kparzysz at codeaurora.org, chandlerc at gmail.com, "benny kra" <benny.kra at gmail.com>, aschwaighofer at apple.com,
> echristo at gmail.com, sanjoy at playingwithpointers.com, hfinkel at anl.gov
> Cc: "james molloy" <james.molloy at arm.com>, "ted woodward" <ted.woodward at codeaurora.org>, llvm-commits at lists.llvm.org
> Sent: Thursday, August 13, 2015 2:54:43 AM
> Subject: Re: [PATCH] D11782: RFC: Target-specific loop idiom recognition
> 
> jmolloy added a subscriber: jmolloy.
> jmolloy added a comment.
> 
> Hi,
> 
> I agree with Hal's comment here. I don't see the value-add for other
> targets from this approach.
> 
> What's the value of calling this from LIR? Your hook isn't leveraging
> off of any of LIR's infrastructure, and that is the usual goal.
> "Take out what is target independent, and keep what is not" -
> There's no target independent stuff being hoisted here, you're just
> running a pass on a loop. You can do that without LIR.
> 
> I think you'd have to describe some functionality being shared here
> before I'll be fully convinced.
> 
> Cheers,
> 
> James
> 
> 
> Repository:
>   rL LLVM
> 
> http://reviews.llvm.org/D11782
> 
> 
> 
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory