[compiler-rt] r244786 - Try to fix the MSVC build now that we use /Zc:inline.

[Kostya Serebryany via llvm-commits]

I think yes.

On Wed, Aug 12, 2015 at 5:17 PM, David Majnemer <david.majnemer at gmail.com>
wrote:

>
>
> On Wed, Aug 12, 2015 at 8:05 PM, Kostya Serebryany via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> You can probably move it to the header -- this function is called only
>> once in this file which is probably why I (or someone else?)
>> added the marker in the .cc file.
>>
>
> Can we do this to the other ALWAYS_INLINE functions in the .cc while
> stripping off the USED attribute?
>
>
>>
>>
>> On Wed, Aug 12, 2015 at 4:39 PM, Rafael Espíndola <
>> rafael.espindola at gmail.com> wrote:
>>
>>> On 12 August 2015 at 17:52, Kostya Serebryany <kcc at google.com> wrote:
>>> > I wonder if you can move the ifdef magic into a header file
>>> > (sanitizer_internal_defs.h)
>>> > Having ifdefs throughout the code is really annoying.
>>>
>>> This code is really peculiar. It has an always_inline marker on the .cpp
>>> file...
>>>
>>> Cheers,
>>> Rafael
>>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150812/d47ebbd0/attachment.html>