[PATCH] D11961: [sancov] Leave llvm.localescape in the entry block
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 12 16:32:23 PDT 2015
rnk added a comment.
In http://reviews.llvm.org/D11961#223310, @samsonov wrote:
> *sigh* looks like anyone who splits basic blocks might stumble to this `localescape` problem. Probably it's worth to put this logic somewhere under lib/Transforms/Utils/BasicBlockUtils.cpp?
I mean, what kind of twisted person wants to split the entry block? It's so non-canonical. ;)
I think most instrumentation passes pretty much need this utility, but no optimization pass needs it. Should I create something like lib/Transforms/Instrumentation/Utils.cpp?
http://reviews.llvm.org/D11961
More information about the llvm-commits
mailing list