[PATCH] D11981: [asan] On OS X, log reports to syslog and os_trace

[Kostya Serebryany via llvm-commits]

kcc added inline comments.

================
Comment at: lib/asan/asan_report.cc:631
@@ +630,3 @@
+// Removes the ANSI escape sequences from the input string (in-place).
+void RemoveANSIEscapeSequencesFromString(char *str) {
+  if (!str)
----------------
OMG, no. 
Instead of removing the ANSI escapes can't we just not emit them? 

================
Comment at: lib/asan/asan_report.cc:707
@@ +706,3 @@
+
+#if SANITIZER_MAC
+    RemoveANSIEscapeSequencesFromString(error_message_buffer);
----------------
Please move large ifdef-ed chunks of code into separate functions


http://reviews.llvm.org/D11981