[PATCH] D11679: [compiler-rt] Add AArch64 to CMake configuration and several missing builtins

[Adhemerval Zanella via llvm-commits]

zatrazz added a comment.

LGTM with the tests comment. I also have tested it with some random inputs (2^26) to check against GCC implementation and everything seems ok.


================
Comment at: test/builtins/Unit/floatunditf_test.c:25
@@ +24,3 @@
+
+COMPILER_RT_ABI long double __floatunditf(long long a);
+
----------------
This should be 'unsigned long long a'.

================
Comment at: test/builtins/Unit/floatunditf_test.c:27
@@ +26,3 @@
+
+int test__floatunditf(long long a, uint64_t expectedHi, uint64_t expectedLo)
+{
----------------
Same as before.

================
Comment at: test/builtins/Unit/floatunditf_test.c:45
@@ +44,3 @@
+#if __LDBL_MANT_DIG__ == 113
+    if (test__floatunditf(0xffffffffffffffff, UINT64_C(0x403effffffffffff), UINT64_C(0xfffe000000000000)))
+        return 1;
----------------
I think it is better to explicit use ULL constants for this all these tests.


Repository:
  rL LLVM

http://reviews.llvm.org/D11679