[llvm] r244406 - cmake: Error on invalid CMAKE_BUILD_TYPE

[Kuperstein, Michael M via llvm-commits]

Great, thanks!

-----Original Message-----
From: Justin Bogner [mailto:justin at justinbogner.com] On Behalf Of Justin Bogner
Sent: Tuesday, August 11, 2015 21:19
To: Kuperstein, Michael M
Cc: llvm-commits at lists.llvm.org
Subject: Re: [llvm] r244406 - cmake: Error on invalid CMAKE_BUILD_TYPE

"Kuperstein, Michael M" <michael.m.kuperstein at intel.com> writes:
> Hi Justin,
>
> I'm not sure erroring out makes sense when generating for Visual 
> Studio (since the solution is always generated with all build types).
> Perhaps disable it for VS?

Ah, the original check only did this if CMAKE_BUILD_TYPE was set, but when I refactored it to case-insensitive I dropped that by mistake.
Fixed in r244643.

> Thanks,
>   Michael
>
> -----Original Message-----
> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On 
> Behalf Of Justin Bogner via llvm-commits
> Sent: Sunday, August 09, 2015 00:05
> To: llvm-commits at lists.llvm.org
> Subject: [llvm] r244406 - cmake: Error on invalid CMAKE_BUILD_TYPE
>
> Author: bogner
> Date: Sat Aug  8 16:04:45 2015
> New Revision: 244406
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244406&view=rev
> Log:
> cmake: Error on invalid CMAKE_BUILD_TYPE
>
> Apparently if you make a typo in the argument to CMAKE_BUILD_TYPE, 
> cmake silently accepts this but doesn't apply any particular build 
> type to your build. This means you get a build that doesn't really 
> make any sense - it's sort of a debug build with asserts disabled.
>
> Error out instead.
>
> Modified:
>     llvm/trunk/CMakeLists.txt
>
> Modified: llvm/trunk/CMakeLists.txt
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=2444
> 06&r1=244405&r2=244406&view=diff 
> ======================================================================
> ========
> --- llvm/trunk/CMakeLists.txt (original)
> +++ llvm/trunk/CMakeLists.txt Sat Aug  8 16:04:45 2015
> @@ -7,6 +7,11 @@ if (NOT CMAKE_BUILD_TYPE AND NOT CMAKE_C
>    set(CMAKE_BUILD_TYPE "Debug")
>  endif()
>  
> +if (CMAKE_BUILD_TYPE AND
> +    NOT CMAKE_BUILD_TYPE MATCHES
> +"^(Debug|Release|RelWithDebInfo|MinSizeRel)$")
> +  message(FATAL_ERROR "Invalid value for CMAKE_BUILD_TYPE: 
> +${CMAKE_BUILD_TYPE}")
> +endif()
> +
>  if(POLICY CMP0022)
>    cmake_policy(SET CMP0022 NEW) # automatic when 2.8.12 is required
>  endif()
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> ---------------------------------------------------------------------
> Intel Israel (74) Limited
>
> This e-mail and any attachments may contain confidential material for 
> the sole use of the intended recipient(s). Any review or distribution 
> by others is strictly prohibited. If you are not the intended 
> recipient, please contact the sender and delete all copies.
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.