[PATCH] D11969: Avoid using of DataLayout::getPointerSize() without address space argument in DWARF info generation

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 22:20:12 PDT 2015


joker.eph added a comment.

Thanks for the details. I think I get this, let me ask a more specific question. What I don't understand right now is how MAI->getPointerSize() get the right size since it does not get an address space either?
It seems to me that any place that is using a single "getPointerSize()" would have the address space problem.
>From what I see, MAI is created by the TargetMachine, that itself gets it from the Subtarget, using a Target specific factory function. So in the end it is just a struct initialized by the Target.
At this point I'm not even sure why MAI has a pointer size in the first place, I'm missing a piece of the puzzle or it does not seem right.


Repository:
  rL LLVM

http://reviews.llvm.org/D11969





More information about the llvm-commits mailing list