[patch] Start fixing pr24429

[David Majnemer via llvm-commits]

I'm afraid I don't see a patch, could you please re-attach one?

On Tue, Aug 11, 2015 at 10:41 PM, Saleem Abdulrasool via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On Tue, Aug 11, 2015 at 1:32 PM, Rafael Espíndola <
> rafael.espindola at gmail.com> wrote:
>
>> Just noticed I forgot llvm-commits. Sorry about that.
>>
>> On 11 August 2015 at 10:52, Rafael Espíndola <rafael.espindola at gmail.com>
>> wrote:
>> > The attached patch just centralizes the knowledge of what file format
>> > is being used in the triple.
>> >
>> > Other than some places that were handling unknown as ELF, this should
>> > have no change. The test updates are because we were detecting
>> > arm-coff or x86_64-win64-coff as ELF targets before.
>> >
>> > Cheers,
>> > Rafael
>>
>
> I really like the underlying idea here.  The only thing that Im not fully
> convinced by is the idea that the enumeration of various file formats we
> support should be part of the triple (purely a movement of the enum).  That
> is something that is definitely outside of the scope of this change.
>
> LGTM.
>
> --
> Saleem Abdulrasool
> compnerd (at) compnerd (dot) org
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150811/54d5d50c/attachment.html>