[PATCH] D11960: [windows] Always use the lit shell on Windows, even if bash is present

[Filipe Cabecinhas via llvm-commits]

filcab added a comment.

In http://reviews.llvm.org/D11960#222184, @yaron.keren wrote:

> The bash shell on Windows from MSYS expands anyhting that looks like a relative path, such as /m.  It has workaround for switches but not for environment vas so tests using 'env' were failing without any way to fix.


Can you provide an example of that issue, please? I'm running all my tests (only ASan and UBSan, for now) on a Windows host (not a Windows target), and I don't seem to see this. Can the issue be solved in another way? Quoting parameters that start with `/X`, for example?

I'm using the bash.exe that comes with git:

  $ bash --version
  GNU bash, version 3.1.20(4)-release (i686-pc-msys)
  Copyright (C) 2005 Free Software Foundation, Inc.



> In addition, it did not pass environment variable TZ since it does not know how ot map between Unix and Windows TZ. This also broke tests.


Which tests? Can this be solved with a script for `%run`? A substitution in lit? It seems like a bug somewhere else. Why is `TZ` not being passed while other env vars are?

> Finally, process creation time on Windows is much higher than on Linux so any command that's implemented internally in the lit shell makes the tests go faster. Note that not all bells and whistles of the commands are really used in the tests.


This tells me that maybe a toggle would be good, to force an internal lit shell. But I don't see the benefit in not running all the tests we can...


http://reviews.llvm.org/D11960