[llvm] r244676 - Fix PR24354.

[David Majnemer via llvm-commits]

Seems fine to me but I'm not code owner of InstCombine.

On Tue, Aug 11, 2015 at 5:55 PM, Hans Wennborg <hans at chromium.org> wrote:

> Should we merge this to 3.7? David, what do you think?
>
> On Tue, Aug 11, 2015 at 2:33 PM, Sanjoy Das via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Author: sanjoy
> > Date: Tue Aug 11 16:33:55 2015
> > New Revision: 244676
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=244676&view=rev
> > Log:
> > Fix PR24354.
> >
> > `InstCombiner::OptimizeOverflowCheck` was asserting an
> > invariant (operands to binary operations are ordered by decreasing
> > complexity) that wasn't really an invariant.  Fix this by instead having
> > `InstCombiner::OptimizeOverflowCheck` establish the invariant if it does
> > not hold.
> >
> > Added:
> >     llvm/trunk/test/Transforms/InstCombine/pr24354.ll
> > Modified:
> >     llvm/trunk/lib/Transforms/InstCombine/InstCombineCompares.cpp
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150811/d384940b/attachment.html>