[PATCH] D11953: [LowerSwitch] Skip dead blocks for processSwitchInst()
Hans Wennborg via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 11 13:12:07 PDT 2015
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm with style comments.
================
Comment at: lib/Transforms/Utils/LowerSwitch.cpp:126
@@ +125,3 @@
+ // waste time processing it.
+ if (DeleteList.count(Cur)) {
+ continue;
----------------
nit: I would probably skip the braces around this one-line if body.
================
Comment at: lib/Transforms/Utils/LowerSwitch.cpp:411
@@ -404,3 +410,3 @@
//
-void LowerSwitch::processSwitchInst(SwitchInst *SI, SmallVectorImpl<BasicBlock*> &DeleteList) {
+void LowerSwitch::processSwitchInst(SwitchInst *SI, SmallPtrSetImpl<BasicBlock*> &DeleteList) {
BasicBlock *CurBlock = SI->getParent();
----------------
This line is over the 80 column limit.
http://reviews.llvm.org/D11953
More information about the llvm-commits
mailing list