[llvm] r244418 - [PHITransAddr] Don't assume that instruction operands are translatable

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 13:02:28 PDT 2015


On Tue, Aug 11, 2015 at 11:46 AM, Chris Lattner <clattner at apple.com> wrote:
>
>> On Aug 11, 2015, at 9:32 AM, Hans Wennborg <hwennborg at google.com> wrote:
>>
>> On Sun, Aug 9, 2015 at 8:43 AM, David Majnemer via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>>> Author: majnemer
>>> Date: Sun Aug  9 10:43:02 2015
>>> New Revision: 244418
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=244418&view=rev
>>> Log:
>>> [PHITransAddr] Don't assume that instruction operands are translatable
>>>
>>> We can only PHI translate instructions.  In our attempt to PHI translate
>>> a bitcast, we attempt to translate its operand; however, the operand
>>> might be an argument or a global instead of an instruction.  Benignly
>>> bail out when this happens.
>>>
>>> This fixes PR24397.
>>
>> We should probably merge this to 3.7.
>>
>> Chris, I don't think we have any other owner here, so this invokes
>> your catch-all. OK to merge?
>
> Sure, LGTM.

Thanks! r244652.


More information about the llvm-commits mailing list