[PATCH] D11915: Let edge weight be always greater than zero in both BPI and MBPI.

David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 11:45:19 PDT 2015


davidxl added a comment.

I thought we need to fix MBPI to handle bad interactions of  with weight normalization and zero weight. Why do we need to fix BPI?


================
Comment at: test/Analysis/BlockFrequencyInfo/bad_input.ll:12
@@ -11,3 +11,3 @@
 
-; Check that we get 1,4 instead of 0,3.
-; CHECK-NEXT: for.body: float = 4.0,
+; Check that we get 1, ~UINT32_MAX instead of 0, 3.
+; CHECK-NEXT: for.body: float = 4294967291.0,
----------------
Do we know what the original intention of the test case is?


http://reviews.llvm.org/D11915





More information about the llvm-commits mailing list