[PATCH] D11942: [GlobalMerge] Use private linkage for MergedGlobals variables

John Brawn via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 07:12:45 PDT 2015


john.brawn created this revision.
john.brawn added reviewers: rafael, ab.
john.brawn added a subscriber: llvm-commits.
john.brawn set the repository for this revision to rL LLVM.

Other objects can never reference the MergedGlobals symbol so external linkage is never needed. Using private instead of internal linkage means the object is more similar to what it looks like when global merging is not enabled, with the only difference being that the merged variables are addressed indirectly relative to the start of the section they are in.

Also add aliases for merged variables with internal linkage, as this also makes the object be more like what it is when they are not merged.

Repository:
  rL LLVM

http://reviews.llvm.org/D11942

Files:
  lib/CodeGen/GlobalMerge.cpp
  test/CodeGen/AArch64/global-merge-1.ll
  test/CodeGen/AArch64/global-merge-2.ll
  test/CodeGen/AArch64/global-merge-3.ll
  test/CodeGen/AArch64/global-merge-4.ll
  test/CodeGen/AArch64/global-merge-group-by-use.ll
  test/CodeGen/AArch64/global-merge-ignore-single-use-minsize.ll
  test/CodeGen/AArch64/global-merge-ignore-single-use.ll
  test/CodeGen/ARM/2011-06-29-MergeGlobalsAlign.ll
  test/CodeGen/ARM/global-merge-1.ll
  test/CodeGen/ARM/global-merge-external.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11942.31809.patch
Type: text/x-patch
Size: 14454 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150811/7ac79697/attachment.bin>


More information about the llvm-commits mailing list