[PATCH] D11530: RFC: LoopEditor, a high-level loop transform toolkit

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 11 03:34:56 PDT 2015


rengolin added a comment.

In http://reviews.llvm.org/D11530#220815, @anemet wrote:

> I rather have as simple classes as possible for things like LoopVersioning, LoopWidening, LoopPeeling, etc and then compose transformations using these classes.  This would make things more explicit and easier to reason about correctness: input, ouput state, required analyses, modified analyses.


I agree with this statement. Having multiple, independent, focused tools, used by multiple, independent passes is a better design.

It may, however, need some redundant information about the state of things on each tool / user, but I think we can manage it.

cheers,
--renato


Repository:
  rL LLVM

http://reviews.llvm.org/D11530





More information about the llvm-commits mailing list