[llvm] r244571 - Fix unused variable 'X' in release builds.

[David Blaikie via llvm-commits]

On Mon, Aug 10, 2015 at 10:57 PM, Nick Lewycky via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: nicholas
> Date: Tue Aug 11 00:57:10 2015
> New Revision: 244571
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244571&view=rev
> Log:
> Fix unused variable 'X' in release builds.
>
> Modified:
>     llvm/trunk/lib/Fuzzer/FuzzerLoop.cpp
>
> Modified: llvm/trunk/lib/Fuzzer/FuzzerLoop.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/FuzzerLoop.cpp?rev=244571&r1=244570&r2=244571&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Fuzzer/FuzzerLoop.cpp (original)
> +++ llvm/trunk/lib/Fuzzer/FuzzerLoop.cpp Tue Aug 11 00:57:10 2015
> @@ -253,9 +253,11 @@ void Fuzzer::WriteToOutputCorpus(const U
>    WriteToFile(U, Path);
>    if (Options.Verbosity >= 2)
>      Printf("Written to %s\n", Path.c_str());
> +#ifdef DEBUG
>    if (Options.OnlyASCII)
>      for (auto X : U)
>        assert(isprint(X) || isspace(X));
> +#endif
>

Not necessary (& not necessarily better... ), but one possible alternative:

assert(!Options.OnlyASCII || std::all_of(U.begin(), U.end(), [](... X) {
return isprint(X) || isspace(X); }));


>  }
>
>  void Fuzzer::WriteUnitToFileWithPrefix(const Unit &U, const char *Prefix)
> {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150810/78ae397c/attachment.html>