[PATCH] D11791: [Windows] Use llvm-symbolizer before using dbghelp

[Reid Kleckner via llvm-commits]

rnk added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_libcdep.cc:273-291
@@ +272,21 @@
+    CHECK(file_line_info);
+    // Parse the last :<int>, which must be there.
+    char *last_colon = internal_strrchr(file_line_info, ':');
+    CHECK(last_colon);
+    int line_or_column;
+    ExtractInt(last_colon + 1, "", &line_or_column);
+    *last_colon = '\0';
+    last_colon = internal_strrchr(file_line_info, ':');
+    if (last_colon && IsDigit(last_colon[1])) {
+      // If the colon before this one is followed by a digit, it must be the
+      // line number, and the previous parsed number was a column.
+      info->line = internal_atoll(last_colon + 1);
+      info->column = line_or_column;
+      *last_colon = '\0';
+    } else {
+      // Otherwise, we have line info but no column info.
+      info->line = line_or_column;
+      info->column = 0;
+    }
+    ExtractToken(file_line_info, "", &info->file);
+    InternalFree(file_line_info);
----------------
This tokenization change here might be worth looking at closely, it's pretty horrible.


http://reviews.llvm.org/D11791