[PATCH] D11316: [X86] -- Fix fptoui i64 conversions for IA32 (performance and correctness)

[Mitch Bodart via llvm-commits]

mbodart added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:12399
@@ +12398,3 @@
+      Low32 = DAG.getNode(ISD::ZERO_EXTEND, DL, MVT::i64, Low32);
+      High32 = DAG.getNode(ISD::ANY_EXTEND, DL, MVT::i64, High32);
+      High32 = DAG.getNode(ISD::SHL, DL, MVT::i64, High32,
----------------
Yes, thanks for the suggestion!

Fixed in latest upload.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:12697
@@ +12696,3 @@
+  // If FP_TO_INTHelper failed, the node is actually supposed to be Legal.
+  if (!FIST.getNode())
+    return Op;
----------------
Fixed, both here and up above in LowerFP_TO_SINT, where this was copied from.


http://reviews.llvm.org/D11316