[PATCH] D11907: LLVM support for -fthinlto option, and gold support for thinlto plugin option.

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 17:14:52 PDT 2015


On Mon, Aug 10, 2015 at 3:00 PM, Peter Collingbourne <peter at pcc.me.uk>
wrote:

> pcc added a subscriber: pcc.
>
> ================
> Comment at: tools/gold/gold-plugin.cpp:132
> @@ -127,1 +131,3 @@
>        TheOutputType = OT_DISABLE;
> +    } else if (opt == "thinlto") {
> +      thinlto = true;
> ----------------
> Do we need a new plugin option? Would it not be possible to determine
> whether ThinLTO is needed by reading the intermediate files?
>

Thanks for the suggestion. Yes, we could do that. It does mean (for the
bitcode representation I proposed last week) that the MODULE_BLOCK would
first need to be scanned for a THINLTO_BLOCK nested directly within it.
I.e. each of the top level blocks and records nested directly within the
module block need to be skipped through. So a bit more compile time. I'm
not sure how much this matters in practice though.


>
>
> http://reviews.llvm.org/D11907
>
>
>
>


-- 
Teresa Johnson | Software Engineer | tejohnson at google.com | 408-460-2413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150810/d500e60e/attachment.html>


More information about the llvm-commits mailing list