[PATCH] D11793: [compiler-rt] Add SourceLocations for float_cast_overflow data.

[Alexey Samsonov via llvm-commits]

samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks for doing this!


================
Comment at: lib/ubsan/ubsan_handlers.cc:297
@@ +296,3 @@
+  u8 *FilenameOrTypeDescriptor;
+  internal_memcpy(&FilenameOrTypeDescriptor, Data,
+                  sizeof(FilenameOrTypeDescriptor));
----------------
Why not reinterpret_cast<u8*>(Data)?

================
Comment at: lib/ubsan/ubsan_handlers.h:114
@@ -106,3 +113,3 @@
 /// \brief Handle overflow in a conversion to or from a floating-point type.
-RECOVERABLE(float_cast_overflow, FloatCastOverflowData *Data, ValueHandle From)
+RECOVERABLE(float_cast_overflow, void *Data, ValueHandle From)
 
----------------
Please add a comment that "void *Data" should be either FloatCastOverflowData* or FloatCastOverflowDataV2*.


http://reviews.llvm.org/D11793