[PATCH] D11316: [X86] -- Fix fptoui i64 conversions for IA32 (performance and correctness)

Mitch Bodart via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 11:31:46 PDT 2015


mbodart updated this revision to Diff 31699.
mbodart added a comment.

I uploaded a new revision, removing all usage of isTargetFTOL and isIntegerTypeFTOL, which I think is sufficient for this change set.  I left the WIN_FTOL instructions, as conceivably those could still be used for conversion to signed int64, though they aren't currently.

I'm still waiting on a recommendation as to whether lit tests should lean towards using -mattr instead of -mcpu.
Please let me know your preference, and whether that applies to all RUN lines.  Specifically, what would be the appropriate -mattr replacement for -mcpu=generic?

thanks!
Mitch Bodart


http://reviews.llvm.org/D11316

Files:
  lib/Target/X86/X86ISelLowering.cpp
  lib/Target/X86/X86ISelLowering.h
  test/CodeGen/X86/pr17631.ll
  test/CodeGen/X86/scalar-fp-to-i64.ll
  test/CodeGen/X86/win_ftol2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11316.31699.patch
Type: text/x-patch
Size: 20959 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150810/854aa642/attachment.bin>


More information about the llvm-commits mailing list