[PATCH] D11854: DeadStoreElimination: remove a redundant store even if the load is in a different block.

Erik Eckstein via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 10:37:47 PDT 2015


eeckstein added a comment.

Thanks for looking at this patch.

> So, Karthik posted and got http://reviews.llvm.org/D11143 reviewed

>  Does this not cover your case?


I checked this and no, it does not cover my case.

Nevertheless thanks for pointing me to Karthik's patch. I think I will invest a little bit more work and use a similar work-list algorithm as Kathik. It will cover more cases: my current approach (with getNonLocalPointerDependency) has the drawback that it does not work if there is a (harmless) other load between the first load and the store.

Also I assume (but I'm not sure) it will be faster than getNonLocalPointerDependency.

I will upload an updated patch soon. But anyway I don't want to commit anything until Kathik's patch has landed so that there are no conflicts.

Thanks,
Erik


http://reviews.llvm.org/D11854





More information about the llvm-commits mailing list