[PATCH] D11839: Adding SymbolRef::getSectionName for getting a textual section name for the symbol. Updating llvm-objdump to use this

Colin LeMahieu via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 09:57:09 PDT 2015


colinl removed rL LLVM as the repository for this revision.
colinl updated this revision to Diff 31681.
colinl marked 6 inline comments as done.
colinl added a comment.

Addressed comments and changed function names to indicate they're for the purpose of objdump.  Maybe with new naming it'll fit in to place better?

It still seems unfortunate to inject objdump specific functions in to the Object library.  If there are ideas on a cleaner way to generate this name WRT to placement and being able to access required functionality, I'm open to input.


http://reviews.llvm.org/D11839

Files:
  include/llvm/Object/ELFObjectFile.h
  include/llvm/Object/MachO.h
  include/llvm/Object/ObjectFile.h
  lib/Object/ELFObjectFile.cpp
  lib/Object/MachOObjectFile.cpp
  lib/Object/ObjectFile.cpp
  tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11839.31681.patch
Type: text/x-patch
Size: 8263 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150810/5d382e7c/attachment.bin>


More information about the llvm-commits mailing list