[PATCH] D11249: Fix PR#24142

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 10 09:27:26 PDT 2015


rnk added a comment.

Michael added getSPAdjust recently, so he can comment on what it should be doing.


================
Comment at: lib/CodeGen/TargetInstrInfo.cpp:664
@@ -663,2 +663,3 @@
   int SPAdj = MI->getOperand(0).getImm();
+  SPAdj = TFI->alignSPAdjust(SPAdj);
 
----------------
I don't think this is the right place to fix this. getSPAdjust is also used on X86 to return SP adjustment values for PUSH, POP, CALL, and others. These typically produce values that are not a multiple of stack alignment (4 / 8 vs 16).


http://reviews.llvm.org/D11249





More information about the llvm-commits mailing list