[PATCH] D11687: Make cost estimation in RewriteLoopExitValues smarter

[Sanjoy Das via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

LGTM with some comments inline.


================
Comment at: include/llvm/Analysis/ScalarEvolutionExpander.h:206
@@ +205,3 @@
+    // didn't find any value it does not mean that there is no such value.
+    Value *tryToGetExistingExpansion(const SCEV *S, const Instruction *At,
+                                     Loop *L);
----------------
How about `findExistingExpansion` then?

================
Comment at: lib/Analysis/ScalarEvolutionExpander.cpp:1851
@@ +1850,3 @@
+
+  // If we can find value for this scev avaliable at the point "At"
+  // consider expression cheap.
----------------
Minor: I'm not a native English speaker, but are there some prepositions missing here?  I'd have expected "If we can find an existing value for this SCEV available at At then consider the expression cheap".


Repository:
  rL LLVM

http://reviews.llvm.org/D11687