[PATCH] D11749: [X86] When optimizing for size, use POP for small post-call stack clean-up

[Reid Kleckner via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

In http://reviews.llvm.org/D11749#217500, @mkuper wrote:

> Updated with David's comments.
>
> Honestly, I liked the SmallVector version better. Are you ok with reverting to that?


I'd rather not. If the STL accessors make things more readable, how about std::array?


================
Comment at: test/CodeGen/X86/pop-stack-cleanup.ll:4
@@ +3,3 @@
+declare void @param1(i32 %a)
+declare i32 @param2_ret(i32 %a, i32 %b)
+declare void @param2(i32 %a, i32 %b)
----------------
Add a test that returns i64 in EAX:EDX and see what we get.


http://reviews.llvm.org/D11749