[PATCH] D11861: [IR] Add token types

[Joseph Tremoulet via llvm-commits]

JosephTremoulet added a comment.

LGTM aside from some questions about the return type exclusion.


================
Comment at: lib/IR/Type.cpp:383
@@ -380,3 +382,3 @@
   return !RetTy->isFunctionTy() && !RetTy->isLabelTy() &&
-  !RetTy->isMetadataTy();
+         !RetTy->isMetadataTy() && !RetTy->isTokenTy();
 }
----------------
Will this preclude having intrinsics that produce tokens?  I'd have thought such a thing would make sense, though I don't have an immediate need for one.

================
Comment at: test/Assembler/token.ll:6
@@ +5,3 @@
+; CHECK: define void @sh16(token
+define void @sh16(token %A) {
+entry:
----------------
Seems odd to allow token parameters but not token returns; I'd have expected each kind of cross-function transfer to cause roughly the same amount of trouble.


http://reviews.llvm.org/D11861