[PATCH] D11363: Allow merging of immediates within a basic block for code size savings and reduced footprint.

Mon Aug 10 02:47:22 PDT 2015

hfinkel added inline comments.

================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:349
@@ +348,3 @@
+                 OtherOp->getOperand(1).getNode())))
+            if (RegNode->getReg() == X86::ESP)
+              continue;
----------------
Do you need to check for X86::RSP here too?

Your test case seems to be 32-bit only. Assuming this affects 64-bit code too, can you please add some coverage for that as well?

http://reviews.llvm.org/D11363