[PATCH] D11530: RFC: LoopEditor, a high-level loop transform toolkit

[Renato Golin via llvm-commits]

rengolin added a comment.

I'm failing to see (partially because it's my first time looking at it) how your new hooks will make sure all the pre-analysis is done before the actual vectorization. But it seems Adam and others are more familiar with it, so I'll just let them comment about that.

Having said that, I welcome any change that makes it easier to share code, and it now seems to me that other loop passes will be able to use the same hooks and reduce their complexity as well as you did in the vectorizer.

cheers,
--renato


================
Comment at: lib/Target/ARM/Thumb2ITBlockPass.cpp:186
@@ -185,2 +185,3 @@
     ARMCC::CondCodes CC = getITInstrPredicate(MI, PredReg);
+
     if (CC == ARMCC::AL) {
----------------
oops


Repository:
  rL LLVM

http://reviews.llvm.org/D11530