[PATCH] D10289: LoopStrengthReduce: Try to pass address space to isLegalAddressingMode

[hfinkel@anl.gov via llvm-commits]

hfinkel accepted this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added a comment.
This revision is now accepted and ready to land.

Either the absence of the address spaces below are mistakes, or please add a comment explaining why the address space should not be passed there. Otherwise, LGTM.


================
Comment at: lib/Transforms/Scalar/LoopStrengthReduce.cpp:2185
@@ -2160,1 +2184,3 @@
+                                          /*BaseOffset=*/0,
+                                          /*HasBaseReg=*/false, Scale))
               goto decline_post_inc;
----------------
Why are you not passing the address space here?


================
Comment at: lib/Transforms/Scalar/LoopStrengthReduce.cpp:2190
@@ -2165,1 +2189,3 @@
+                                          /*BaseOffset=*/0,
+                                          /*HasBaseReg=*/false, Scale))
               goto decline_post_inc;
----------------
And here?


http://reviews.llvm.org/D10289