[PATCH] D11612: [lld][ELF2] Apply relocations.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 7 15:32:48 PDT 2015


ruiu added a comment.

I was thinking about the cost. I'm still thinking but I don't want to block this,
so writing a comment. I still prefer to not write code for relocations in Writer.cpp,
as I think the original code is much more cleaner than this is.

I believe it shouldn't be hard to rewrite it as one pass if we have to.
So it looks like a premature optimization to me.


http://reviews.llvm.org/D11612





More information about the llvm-commits mailing list