[PATCH] Remove the global pseudo source values manager variable and convert the MipsCallEntry subclass into target neutral subclasses.

Akira Hatanaka via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 7 13:09:23 PDT 2015


Hi Alex,

The patch looks fine to me.

On Thu, Aug 6, 2015 at 3:11 PM, Alex L <arphaman at gmail.com> wrote:

> Hi,
>
> There are 5 patches attached below:
>
> - The first one runs clang-format on PseudoSourceValue.cpp and
> PseudoSourceValue.h
>
> - The second one fixes some documentation comments and variable names in
>    PseudoSourceValue.cpp and PseudoSourceValue.h.
>
> - The third patch introduces a new PSVKind enum in PseudoSourceValue
> class, which is used
>    to distinguish between the various types of pseudo source values.
>
> -  The fourth patch removes the global manager variable which is
> responsible for storing
>    and allocating pseudo source values and instead it uses a new manager
> class which
>    is owned by the machine function.
>
> -  The fifth patch converts the MipsCallEntry PseudoSourceValue subclass
> into two
>     target neutral PseudoSourceValue subclasses:
> GlobalValuePseudoSourceValue
>     and ExternalSymbolPseudoSourceValue.
>
> These changes will make it easier to serialize pseudo source values by
> getting rid
> of all the target specific pseudo source value subclasses in tree.
>
> Cheers,
> Alex
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150807/7d9d8c43/attachment.html>


More information about the llvm-commits mailing list