[PATCH] D11805: Make DwarfAccelTable customizable. NFC.

Frederic Riss via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 7 10:16:28 PDT 2015


friss added a comment.

I have this revision lying around where the code is driven by what's in the atom list:
http://reviews.llvm.org/D8215 (it's based on this other one http://reviews.llvm.org/D8216 that you ack'd but that I didn't commit as it doesn't make much sense without the former)

I find this approach clearer. Rather than adding a special case for storing DIE offsets instead of DIE pointers, I'll just derive a new table type.

As I mentioned, Adrian has a use that create a totally different table without even DIEs. He's still pondering if he wants to upstream that or do it differently, but this one would make the code even uglier with other special cases.


http://reviews.llvm.org/D11805





More information about the llvm-commits mailing list