[PATCH] D11330: [LIT] Add a .gitignore to llvm/utils/lit

[Eric Fiselier via llvm-commits]

The problem is a little more complex than that. The LIT tests have a
number of different "test" LIT test suites. Each of these "test"
test-suites create temporary files in the source directories. In order
to prevent this we need to rewrite a number of the LIT tests to
propagate the temporary file directory that we would like used.

Once I have this worked out I would be happy to add a check-lit target.

/Eric

On Fri, Aug 7, 2015 at 12:39 PM, Duncan P. N. Exon Smith
<dexonsmith at apple.com> wrote:
>
>> On 2015-Aug-06, at 15:45, Justin Bogner via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>> (Sorry for the re-send, sent to the old list)
>>
>> Eric Fiselier <eric at efcs.ca> writes:
>>> EricWF added a comment.
>>>
>>> In http://reviews.llvm.org/D11330#208648, @chandlerc wrote:
>>>
>>>> So, I don't think we should support testing in-tree because I don't
>>>> like dirtying the tree.
>>>
>>>
>>> "testing in-tree" is probably the wrong way to describe it. Currently
>>> LIT doesn't generate a `check-lit` rule
>>> or a `lit.site.cfg` file. The only way (that I know of) to test LIT is
>>> to run `lit.py llvm-src/utils/lit/tests`. Because this doesn't
>>> set the `config.test_exec_root` option the ShTest temporary directory
>>> will be `llvm-src/utils/lit/tests/Output`.
>>
>> FWIW, I don't think anyone would object to adding a check-lit (or
>> check-llvm-lit or whatever) target in llvm's cmake. Would that solve the
>> problem for you?
>
> +1, I like this idea.
>
>>
>>> One way to keep the tree clean would be to set `config.test_exec_root`
>>> to a created temporary directory. However
>>> I don't think this directory can be cleaned up though (other than by the OS).
>>>
>>> In http://reviews.llvm.org/D11330#208648, @chandlerc wrote:
>>>
>>>> What is the issue with .pyc files? I don't see how you get to that
>>>> being a problem.
>>>
>>>
>>> This is a problem I have outside of my LLVM work (so it's not a real
>>> reason to make this change). I use LIT on other projects as a git
>>> submodule. The LIT submodule is just `llvm/utils/lit` so
>>> `llvm/.gitignore` is not present. When python ends up generating the
>>> `llvm/utils/lit/lit/*.pyc` files they are not ignored by version
>>> control.
>>>
>>> In http://reviews.llvm.org/D11330#208658, @jroelofs wrote:
>>>
>>>> If you don't want *.pyc files, why not set the
>>>> `PYTHONDONTWRITEBYTECODE` env var, or `sys.dont_write_bytecode =
>>>> false`, or use `python -B`?
>>>
>>>
>>> I don't mind the `*.pyc` files, I just want version control to ignore
>>> them when I'm using LIT as a submodule.
>>>
>>>
>>> Repository:
>>>  rL LLVM
>>>
>>> http://reviews.llvm.org/D11330
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>