[llvm] r244303 - ELF: Add AMDGPU specific defintions

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 6 19:05:04 PDT 2015


On Thu, Aug 6, 2015 at 6:35 PM, Tom Stellard via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: tstellar
> Date: Thu Aug  6 20:35:24 2015
> New Revision: 244303
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244303&view=rev
> Log:
> ELF: Add AMDGPU specific defintions
>

Hi Tom,

> Reviewers: rafael
>
> Subscribers: llvm-commits
>

> -  W.printEnum  ("Type", Symbol->getType(), makeArrayRef(ElfSymbolTypes));
> +  if (Obj->getHeader()->e_machine == ELF::EM_AMDGPU &&
> +      SymbolType >= ELF::STT_LOOS && SymbolType < ELF::STT_HIOS)

I think the second check can be spelled as sym->isOSSpecific().

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare


More information about the llvm-commits mailing list