[PATCH] D11780: -Wdeprecated: Use noexcept rather than throw() where supported

[Alexey Samsonov via llvm-commits]

samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/sanitizer_common/sanitizer_internal_defs.h:146
@@ -145,3 +145,3 @@
 # define THREADLOCAL   __thread
-# define NOTHROW throw()
+# define NOTHROW NOEXCEPT
 # define LIKELY(x)     __builtin_expect(!!(x), 1)
----------------
Please don't define one macro through another. Also, this macro seem to be unused, maybe we can just delete it?

================
Comment at: lib/sanitizer_common/sanitizer_internal_defs.h:166
@@ +165,3 @@
+#if !defined(_MSC_VER) || defined(__clang__) || MSC_PREREQ(1900)
+#define NOEXCEPT noexcept
+#else
----------------
Indentation and below:
  #if blah
  # define FOO bar
  #endif

================
Comment at: lib/sanitizer_common/sanitizer_platform.h:145
@@ -144,1 +144,3 @@
 
+/// \macro LLVM_MSC_PREREQ
+/// \brief Is the compiler MSVC of at least the specified version?
----------------
Remove reference to `LLVM_MSC_PREREQ`


http://reviews.llvm.org/D11780