[PATCH] D11819: [RewriteStatepointsForGC] Avoid using unrelocated pointers after safepoints

[Philip Reames via llvm-commits]

reames created this revision.
reames added reviewers: sanjoy, chenli, pgavlin, swaroop.sridhar.
reames added a subscriber: llvm-commits.

To be clear: this is an *optimization* not a correctness change.

CodeGenPrep likes to duplicate icmps feeding branch instructions to take advantage of x86's ability to fuze many comparison/branch patterns into a single micro-op and to reduce the need for materializing i1s into general registers.  PlaceSafepoints likes to place safepoint polls right at the end of basic blocks (immediately before terminators) when inserting entry and backedge safepoints.  These two heuristics interact in a somewhat unfortunate way where the branch terminating the original block will be controlled by a condition driven by unrelocated pointers.  This forces the register allocator to keep both the relocated and unrelocated values of the pointers feeding the icmp alive over the safepoint poll.  

One simple fix would have been to just adjust PlaceSafepoints to move one back in the basic block, but you can reach similar cases as a result of LICM or other hoisting passes.  As a result, doing a post insertion fixup seems to be more robust.  

I considered doing this in CodeGenPrep itself, but having to update the live sets of already rewritten safepoints gets complicated fast.  In particular, you can't just use def/use information because by moving the icmp, we're extending the live range of it's inputs potentially.  

Instead, this patch teaches RewriteStatepointsForGC to make the required adjustments before making the relocations explicit in the IR.  This change really highlights the fact that RSForGC is a CodeGenPrep-like pass which is performing target specific lowering.  In the long run, we may even want to combine the two though this would require a lot more smarts to be integrated into RSForGC first.  We currently rely on being able to run a set of cleanup passes post rewriting because the IR RSForGC generates is pretty damn ugly.  

http://reviews.llvm.org/D11819

Files:
  lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
  test/Transforms/RewriteStatepointsForGC/codegen-cond.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11819.31472.patch
Type: text/x-patch
Size: 4572 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150806/dd23263c/attachment.bin>