[compiler-rt] r244136 - [sanitizer] Add the flag handle_sigfpe that is default true to handle SIGFPE crashes same as SIGSEV crashes, patch by Karl Skomski

[Kostya Serebryany via llvm-commits]

+Karl, author of the patch.

Thanks for reverting and sorry for the breakage.
I don't have access to ARM myself, nor much experience with it.
Any ideas what might have gone wrong?

I am tempted to re-apply the patch w/o the AddressSanitizer.FPECrashTest
test -- the same functionality
is also covered by a lit test which did not seem to fail on ARM. WDYT?


On Thu, Aug 6, 2015 at 5:43 AM, Renato Golin <renato.golin at linaro.org>
wrote:

> Sorry, reverted in r244210, we should investigate what's wrong offline.
>
> cheers,
> --renato
>
> On 6 August 2015 at 10:04, Renato Golin <renato.golin at linaro.org> wrote:
> > On 5 August 2015 at 22:19, Kostya Serebryany <kcc at google.com> wrote:
> >> Author: kcc
> >> Date: Wed Aug  5 16:19:11 2015
> >> New Revision: 244136
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=244136&view=rev
> >> Log:
> >> [sanitizer] Add the flag handle_sigfpe that is default true to handle
> SIGFPE crashes same as SIGSEV crashes, patch by Karl Skomski
> >
> > Hi Kostya,
> >
> > It seems this commit broke our ARM bots:
> >
> > http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/6917
> >
> >
> http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/1885
> >
> > You haven't been warned because there were other failures in there,
> > that are now gone.
> >
> > cheers,
> > --renato
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150806/540d5df4/attachment.html>