[PATCH] llvm-build: Adopt generation of LLVM_LIBS_TO_EXPORT

[Brad King via llvm-commits]

On 08/06/2015 02:42 AM, Dan Liew wrote:
> I've given a try and it seems to work. My only comments would be that
> the the LLVM_LIBS_TO_EXPORTED in Makefile.llvmbuild. Contains
> ``gtest`` and ``gtest_main`` which they probably shouldn't given the
> variable's name. The ``cmake/modules/Makefile`` has some logic to
> remove this but perhaps we should consider preventing LLVMBuild from
> exporting gtest and gtest_main instead? CC'ing Takumi because, Takumi
> raised this issue a while ago [1].

Actually while working on these patches I had a third patch after
these specifically to move the gtest filtering over to llvm-build.
I decided to leave it out originally to avoid conflating the bug
fix with extra refactoring.

I've reworded the first two patches to makes sense for application
after r244108 fixed issue #24154 and added the third patch for gtest
filtering.  See attached.

Thanks,
-Brad

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-llvm-build-Factor-out-duplicate-cmake-export-listing.patch
Type: text/x-diff
Size: 4383 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150806/1ed6b183/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-llvm-build-Adopt-generation-of-LLVM_LIBS_TO_EXPORT.patch
Type: text/x-diff
Size: 4016 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150806/1ed6b183/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-llvm-build-Filter-gtest-libraries-out-of-CMake-expor.patch
Type: text/x-diff
Size: 3799 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150806/1ed6b183/attachment-0002.patch>