[Patch] LangRef.rst: Minor typo and whitespace fixes

[Débora Setton Sanches via llvm-commits]

On Wed, Aug 5, 2015 at 4:01 PM, David Wiberg <dwiberg at gmail.com> wrote:

> 2015-08-05 15:30 GMT+02:00 Débora Setton Sanches <setton.debora at gmail.com
> >:
> > Hi,
> >
> > While I was reading the IR documentation the other day, I took note of a
> few
> > small typos and grouped them in the patch that is attached.
> >
> > It's really simple stuff, but I think they improve the text nonetheless,
> > so... Here you go! :)
> >
> > Thanks,
> >
> > Débora.
> >
>
> Hi Débora,
>
> The changes look good to me. I noticed a couple of extra white spaces
> between words while reading the patch. Perhaps you can fix it before
> this is committed, see below.
>
> <start patch snippets>
> +value in the metadata node. This is analogous to the ''dereferenceable''
> +attribute on parameters and return values.  This metadata can only be
> applied
>
> +value in the metadata node. This is analogous to the
> ''dereferenceable_or_null''
> +attribute on parameters and return values.  This metadata can only be
> applied
> <end patch snippets>
>
> There are some more of the same kind in the file but these are the
> ones on lines which you've changed.
>
> Best regards
> David
>
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> >
>


Hi David,

Thanks for reviewing this!

I hadn't noticed the double whitespace issue. After you mentioned that, I
fixed the original patch (see v2 attached), and I also wanted to send a
separate patch fixing only this specific issue for the whole file.

Since I didn't know how to do that with svn (since svn doesn't have the
concept of "local commits"), the second patch is a `git diff` instead of an
`svn diff`, is that ok? How should I have done that with svn?

Thanks,

Débora.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150806/6fa3ce7d/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: LangRef.rst-Typo-Fixes.v2.patch
Type: text/x-patch
Size: 5852 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150806/6fa3ce7d/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: LangRef.rst-Double-Whitespace-Fixes.patch
Type: text/x-patch
Size: 37868 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150806/6fa3ce7d/attachment-0003.bin>