[PATCH] D11780: -Wdeprecated: Use noexcept rather than throw() where supported

[Alexey Samsonov]

samsonov added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_internal_defs.h:122
@@ -121,1 +121,3 @@
 
+/// \macro LLVM_MSC_PREREQ
+/// \brief Is the compiler MSVC of at least the specified version?
----------------
This is irrelevant

================
Comment at: lib/sanitizer_common/sanitizer_internal_defs.h:130
@@ +129,3 @@
+
+// We require at least MSVC 2013.
+#if !MSC_PREREQ(1800)
----------------
This (together with MSC_PREREQ def) can probably go to sanitizer_platform.h (where we define which OS are not supported).

================
Comment at: lib/sanitizer_common/sanitizer_internal_defs.h:140
@@ +139,3 @@
+#if !defined(_MSC_VER) || defined(__clang__) || MSC_PREREQ(1900)
+#define NOEXCEPT noexcept
+#else
----------------
Please move this below (under `//Platform-specific defs`) for consistency. I also don't quite like defining one macro via another (their order becomes important).


http://reviews.llvm.org/D11780