[llvm] r244019 - [llvm-objdump] Call exit(1) on error, i.e. fail early.
Davide Italiano
davide at freebsd.org
Wed Aug 5 17:20:01 PDT 2015
On Wed, Aug 5, 2015 at 5:30 AM, Rafael EspĂndola
<rafael.espindola at gmail.com> wrote:
>> -bool llvm::error(std::error_code EC) {
>> +void llvm::error(std::error_code EC) {
>> if (!EC)
>> - return false;
>> + return;
>>
>> outs() << ToolName << ": error reading file: " << EC.message() << ".\n";
>> outs().flush();
>> - ReturnValue = EXIT_FAILURE;
>> - return true;
>> }
>
> This should be calling exit(1) (or report_error).
>
> Cheers,
> Rafael
Sorry, I got this mail only half an hour ago. r244184.
Thanks for reporting.
--
Davide
"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare
More information about the llvm-commits
mailing list