[PATCH] D11791: [Windows] Use llvm-symbolizer before using dbghelp

[Reid Kleckner]

rnk created this revision.
rnk added a reviewer: samsonov.
rnk added a subscriber: llvm-commits.

llvm-symbolizer understands both PDBs and DWARF, so it's a better bet if
it's available. It prints out the function parameter types and column
numbers, so I needed to churn the expected test output a bit.

This makes most of the llvm-symbolizer subprocessing code
target-independent. Pipes on all platforms use fd_t, and we can use the
portable ReadFromFile / WriteToFile wrappers in symbolizer_sanitizer.cc.
Only the pipe creation and process spawning is Windows-specific.

Please check that the libcdep layering is still correct. I don't know
how to reproduce the build configuration that relies on that.

http://reviews.llvm.org/D11791

Files:
  lib/sanitizer_common/CMakeLists.txt
  lib/sanitizer_common/sanitizer_common.cc
  lib/sanitizer_common/sanitizer_posix.cc
  lib/sanitizer_common/sanitizer_symbolizer.cc
  lib/sanitizer_common/sanitizer_symbolizer_internal.h
  lib/sanitizer_common/sanitizer_symbolizer_mac.cc
  lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc
  lib/sanitizer_common/sanitizer_symbolizer_process_libcdep.cc
  lib/sanitizer_common/sanitizer_symbolizer_win.cc
  lib/sanitizer_common/sanitizer_symbolizer_win.h
  lib/sanitizer_common/sanitizer_win.cc
  test/asan/CMakeLists.txt
  test/asan/TestCases/Windows/bitfield_uaf.cc
  test/asan/TestCases/Windows/demangled_names.cc
  test/asan/TestCases/Windows/dll_noreturn.cc
  test/asan/TestCases/Windows/dll_poison_unpoison.cc
  test/asan/TestCases/Windows/dll_stack_use_after_return.cc
  test/asan/TestCases/Windows/dll_thread_stack_array_left_oob.cc
  test/asan/TestCases/Windows/fuse-lld.cc
  test/asan/TestCases/Windows/null_deref.cc
  test/asan/TestCases/Windows/operator_delete_wrong_argument.cc
  test/asan/TestCases/Windows/operator_new_left_oob.cc
  test/asan/TestCases/Windows/operator_new_right_oob.cc
  test/asan/TestCases/Windows/operator_new_uaf.cc
  test/asan/TestCases/Windows/queue_user_work_item_report.cc
  test/asan/TestCases/Windows/report_after_syminitialize.cc
  test/asan/TestCases/Windows/stack_use_after_return.cc
  test/asan/TestCases/Windows/symbols_path.cc
  test/asan/TestCases/Windows/thread_stack_array_left_oob.cc
  test/asan/TestCases/Windows/thread_stack_array_right_oob.cc
  test/asan/lit.cfg
  test/asan/lit.site.cfg.in

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11791.31418.patch
Type: text/x-patch
Size: 50487 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150805/6ec115f9/attachment.bin>